Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2946a52a authored by Daniel De Graaf's avatar Daniel De Graaf Committed by Konrad Rzeszutek Wilk
Browse files

xenbus: Use grant-table wrapper functions 



For xenbus_{map,unmap}_ring to work on HVM, the grant table operations
must be set up using the gnttab_set_{map,unmap}_op functions instead of
directly populating the fields of gnttab_map_grant_ref. These functions
simply populate the structure on paravirtualized Xen; however, on HVM
they must call __pa() on vaddr when populating op->host_addr because the
hypervisor cannot directly interpret guest-virtual addresses.

Signed-off-by: default avatarDaniel De Graaf <dgdegra@tycho.nsa.gov>
[v1: Fixed cleanpatch error]
Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
parent 2c5d37d3

drivers/xen/xenbus/xenbus_client.c

+7 −10
Original line number Diff line number Diff line
@@ -567,12 +567,10 @@ static int xenbus_map_ring_valloc_hvm(struct xenbus_device *dev, 
int xenbus_map_ring(struct xenbus_device *dev, int gnt_ref,

		    grant_handle_t *handle, void *vaddr)

{

	struct gnttab_map_grant_ref op = {

		.host_addr = (unsigned long)vaddr,

		.flags     = GNTMAP_host_map,

		.ref       = gnt_ref,

		.dom       = dev->otherend_id,

	};

	struct gnttab_map_grant_ref op;



	gnttab_set_map_op(&op, (phys_addr_t)vaddr, GNTMAP_host_map, gnt_ref,

			  dev->otherend_id);



	if (HYPERVISOR_grant_table_op(GNTTABOP_map_grant_ref, &op, 1))

		BUG();
@@ -698,10 +696,9 @@ static int xenbus_unmap_ring_vfree_hvm(struct xenbus_device *dev, void *vaddr) 
int xenbus_unmap_ring(struct xenbus_device *dev,

		      grant_handle_t handle, void *vaddr)

{

	struct gnttab_unmap_grant_ref op = {

		.host_addr = (unsigned long)vaddr,

		.handle    = handle,

	};

	struct gnttab_unmap_grant_ref op;



	gnttab_set_unmap_op(&op, (phys_addr_t)vaddr, GNTMAP_host_map, handle);



	if (HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, &op, 1))

		BUG();