Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28ce280f authored by Martin K. Petersen's avatar Martin K. Petersen Committed by James Bottomley
Browse files

[SCSI] 3w-xxxx: Create sense buffer for unsupported commands 



Make the driver return appropriate sense data when an unsupported
operation is queued. This will cause the SCSI layer to stop issuing the
offending command.

Reported-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Acked-by: default avatarAdam Radford <aradford@gmail.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 56f2a801

drivers/scsi/3w-xxxx.c

+3 −1
Original line number Diff line number Diff line
@@ -216,6 +216,7 @@ 
#include <scsi/scsi_host.h>

#include <scsi/scsi_tcq.h>

#include <scsi/scsi_cmnd.h>

#include <scsi/scsi_eh.h>

#include "3w-xxxx.h"



/* Globals */
@@ -2009,7 +2010,8 @@ static int tw_scsi_queue_lck(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_c 
			printk(KERN_NOTICE "3w-xxxx: scsi%d: Unknown scsi opcode: 0x%x\n", tw_dev->host->host_no, *command);

			tw_dev->state[request_id] = TW_S_COMPLETED;

			tw_state_request_finish(tw_dev, request_id);

			SCpnt->result = (DID_BAD_TARGET << 16);

			SCpnt->result = (DRIVER_SENSE << 24) | SAM_STAT_CHECK_CONDITION;

			scsi_build_sense_buffer(1, SCpnt->sense_buffer, ILLEGAL_REQUEST, 0x20, 0);

			done(SCpnt);

			retval = 0;

	}