Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 287aa83d authored by Bill Nottingham's avatar Bill Nottingham Committed by Jeff Garzik
Browse files

drivers/net: fix comparisons of unsigned < 0 



Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0.

Signed-off-by: default avatarBill Nottingham <notting@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 40738f3f

drivers/net/mlx4/qp.c

+1 −2
Original line number Diff line number Diff line
@@ -113,8 +113,7 @@ int mlx4_qp_modify(struct mlx4_dev *dev, struct mlx4_mtt *mtt, 
	struct mlx4_cmd_mailbox *mailbox;

	int ret = 0;



	if (cur_state < 0 || cur_state >= MLX4_QP_NUM_STATE ||

	    new_state < 0 || cur_state >= MLX4_QP_NUM_STATE ||

	if (cur_state >= MLX4_QP_NUM_STATE || cur_state >= MLX4_QP_NUM_STATE ||

	    !op[cur_state][new_state])

		return -EINVAL;

drivers/net/netxen/netxen_nic_niu.c

+3 −3
Original line number Diff line number Diff line
@@ -724,7 +724,7 @@ int netxen_niu_disable_gbe_port(struct netxen_adapter *adapter) 
	__u32 mac_cfg0;

	u32 port = physical_port[adapter->portnum];



	if ((port < 0) || (port > NETXEN_NIU_MAX_GBE_PORTS))

	if (port > NETXEN_NIU_MAX_GBE_PORTS)

		return -EINVAL;

	mac_cfg0 = 0;

	netxen_gb_soft_reset(mac_cfg0);
@@ -757,7 +757,7 @@ int netxen_niu_set_promiscuous_mode(struct netxen_adapter *adapter, 
	__u32 reg;

	u32 port = physical_port[adapter->portnum];



	if ((port < 0) || (port > NETXEN_NIU_MAX_GBE_PORTS))

	if (port > NETXEN_NIU_MAX_GBE_PORTS)

		return -EINVAL;



	/* save previous contents */
@@ -894,7 +894,7 @@ int netxen_niu_xg_set_promiscuous_mode(struct netxen_adapter *adapter, 
	__u32 reg;

	u32 port = physical_port[adapter->portnum];



	if ((port < 0) || (port > NETXEN_NIU_MAX_XG_PORTS))

	if (port > NETXEN_NIU_MAX_XG_PORTS)

		return -EINVAL;



	if (netxen_nic_hw_read_wx(adapter,

drivers/net/tulip/de2104x.c

+0 −1
Original line number Diff line number Diff line
@@ -785,7 +785,6 @@ static void __de_set_rx_mode (struct net_device *dev) 


	de->tx_head = NEXT_TX(entry);



	BUG_ON(TX_BUFFS_AVAIL(de) < 0);

	if (TX_BUFFS_AVAIL(de) == 0)

		netif_stop_queue(dev);