Commit 28693ec0 authored Jan 24, 2011 by Julia Lawall Committed by Kevin Hilman Jan 24, 2011

OMAP: PM: SmartReflex: Add missing IS_ERR test

Function _sr_lookup, defined in the same file, returns ERR_PTR not NULL in
an error case.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@r@
identifier f;
@@
f(...) { ... return ERR_PTR(...); }

@@
identifier r.f, fld;
expression x;
statement S1,S2;
@@
 x = f(...)
 ... when != IS_ERR(x)
(
 if (IS_ERR(x) ||...) S1 else S2
|
*x->fld
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Kevin Hilman <khilman@ti.com>

parent 1bae4ce2

arch/arm/mach-omap2/smartreflex.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -966,7 +966,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev)
		}

		sr_info = _sr_lookup(pdata->voltdm);
		if (!sr_info) {
		if (IS_ERR(sr_info)) {
		dev_warn(&pdev->dev, "%s: omap_sr struct not found\n",
		__func__);
		return -EINVAL;