Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 271b874b authored by Brian Norris's avatar Brian Norris Committed by David Woodhouse
Browse files

mtd: nand: gpmi: need to use {read,write}_oob_raw 



This patch is simply an added warning in the comments. Ideally, this patch
need not be merged, but rather, a developer will write a proper solution
that can use the ecc.read_oob_raw and ecc.write_oob_raw interfaces.

Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>
Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent b9bc815c

drivers/mtd/nand/gpmi-nand/gpmi-nand.c

+3 −0
Original line number Diff line number Diff line
@@ -1064,6 +1064,9 @@ static void gpmi_ecc_write_page(struct mtd_info *mtd, struct nand_chip *chip, 
 * ECC-based or raw view of the page is implicit in which function it calls

 * (there is a similar pair of ECC-based/raw functions for writing).

 *

 * FIXME: The following paragraph is incorrect, now that there exist

 * ecc.read_oob_raw and ecc.write_oob_raw functions.

 *

 * Since MTD assumes the OOB is not covered by ECC, there is no pair of

 * ECC-based/raw functions for reading or or writing the OOB. The fact that the

 * caller wants an ECC-based or raw view of the page is not propagated down to