Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26bbb3ff authored by Daniel Glöckner's avatar Daniel Glöckner Committed by Linus Torvalds
Browse files

imx: serial: fix one bit field type 



"have_rtscts" is assigned 1, while it is declared
int:1, two's complement, which can hold 0 and -1
only. The code works, as the upper bits are cut
off, and tests are done against 0 only.

Nonetheless, correctly declaring the bit field
as unsigned int:1 renders the code more robust.

Signed-off-by: default avatarDaniel Glöckner <dg@emlix.com>
Signed-off-by: default avatarOskar Schirmer <os@emlix.com>
Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d3810cd4

drivers/serial/imx.c

+1 −1
Original line number Diff line number Diff line
@@ -211,7 +211,7 @@ struct imx_port { 
	struct timer_list	timer;

	unsigned int		old_status;

	int			txirq,rxirq,rtsirq;

	int			have_rtscts:1;

	unsigned int		have_rtscts:1;

	struct clk		*clk;

};