Commit 253262a5 authored Jul 03, 2013 by Jingoo Han Committed by Linus Torvalds Jul 03, 2013

rtc: rtc-pm8xxx: remove unnecessary platform_set_drvdata()



The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d063 ("device-core: Ensure drvdata
= NULL when no driver is bound").  Thus, it is not needed to manually
clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a1c805a9

drivers/rtc/rtc-pm8xxx.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -480,7 +480,6 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)
		fail_req_irq:
		rtc_device_unregister(rtc_dd->rtc);
		fail_rtc_enable:
		platform_set_drvdata(pdev, NULL);
		kfree(rtc_dd);
		return rc;
		}
		@@ -492,7 +491,6 @@ static int pm8xxx_rtc_remove(struct platform_device *pdev)
		device_init_wakeup(&pdev->dev, 0);
		free_irq(rtc_dd->rtc_alarm_irq, rtc_dd);
		rtc_device_unregister(rtc_dd->rtc);
		platform_set_drvdata(pdev, NULL);
		kfree(rtc_dd);

		return 0;