Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 24e2fb61 authored Aug 02, 2009 by Roel Kluin Committed by Steve French Aug 03, 2009

cifs: Read buffer overflow



Check whether index is within bounds before testing the element.

Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent 4486d6ed

fs/cifs/cifs_unicode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -44,7 +44,7 @@ cifs_ucs2_bytes(const __le16 *from, int maxbytes,
		int maxwords = maxbytes / 2;
		char tmp[NLS_MAX_CHARSET_SIZE];

		for (i = 0; from[i] && i < maxwords; i++) {
		for (i = 0; i < maxwords && from[i]; i++) {
		charlen = codepage->uni2char(le16_to_cpu(from[i]), tmp,
		NLS_MAX_CHARSET_SIZE);
		if (charlen > 0)