Commit 240936e1 authored Apr 26, 2007 by Akinobu Mita Committed by Greg Kroah-Hartman Apr 27, 2007

mod_sysfs_setup() doesn't return errno when kobject_add_dir() failure occurs



mod_sysfs_setup() doesn't return an errno when kobject_add_dir() for module
"holders" directory fails.  So caller of mod_sysfs_setup() will keep going
and get oops.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent a53c46dc

kernel/module.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1148,8 +1148,10 @@ int mod_sysfs_setup(struct module *mod,
		goto out;

		mod->holders_dir = kobject_add_dir(&mod->mkobj.kobj, "holders");
		if (!mod->holders_dir)
		if (!mod->holders_dir) {
		err = -ENOMEM;
		goto out_unreg;
		}

		err = module_param_sysfs_setup(mod, kparam, num_params);
		if (err)