Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23a0e27a authored by Paul Walmsley's avatar Paul Walmsley Committed by Thierry Reding
Browse files

gpu: host1x: clk_round_rate() can return a zero upon error



Treat both negative and zero return values from clk_round_rate() as
errors.  This is needed since subsequent patches will convert
clk_round_rate()'s return value to be an unsigned type, rather than a
signed type, since some clock sources can generate rates higher than
(2^31)-1 Hz.

Eventually, when calling clk_round_rate(), only a return value of zero
will be considered a error.  All other values will be considered valid
rates.  The comparison against values less than 0 is kept to preserve
the correct behavior in the meantime.

Signed-off-by: default avatarPaul Walmsley <pwalmsley@nvidia.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: Arto Merilainen <amerilainen@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Terje Bergström <tbergstrom@nvidia.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 8e0d788c
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -960,7 +960,7 @@ static int tegra_output_hdmi_check_mode(struct tegra_output *output,
	parent = clk_get_parent(hdmi->clk_parent);
	parent = clk_get_parent(hdmi->clk_parent);


	err = clk_round_rate(parent, pclk * 4);
	err = clk_round_rate(parent, pclk * 4);
	if (err < 0)
	if (err <= 0)
		*status = MODE_NOCLOCK;
		*status = MODE_NOCLOCK;
	else
	else
		*status = MODE_OK;
		*status = MODE_OK;