Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2384f55f authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

[PATCH] coredump_wait() cleanup 



This patch deletes pointless code from coredump_wait().

1. It does useless mm->core_waiters inc/dec under mm->mmap_sem,
   but any changes to ->core_waiters have no effect until we drop
   ->mmap_sem.

2. It calls yield() for absolutely unknown reason.

Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 7407251a

fs/exec.c

+5 −8
Original line number Diff line number Diff line
@@ -1417,19 +1417,16 @@ static void zap_threads (struct mm_struct *mm) 
static void coredump_wait(struct mm_struct *mm)

{

	DECLARE_COMPLETION(startup_done);

	int core_waiters;



	mm->core_waiters++; /* let other threads block */

	mm->core_startup_done = &startup_done;



	/* give other threads a chance to run: */

	yield();



	zap_threads(mm);

	if (--mm->core_waiters) {

	core_waiters = mm->core_waiters;

	up_write(&mm->mmap_sem);



	if (core_waiters)

		wait_for_completion(&startup_done);

	} else

		up_write(&mm->mmap_sem);

	BUG_ON(mm->core_waiters);

}