Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2381097b authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: add an error test for no space before comma 



Using code like:

    int foo , bar;

is not preferred to:

    int foo, bar;

so emit an error on this style.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 69c953c8

scripts/checkpatch.pl

+21 −2
Original line number Diff line number Diff line
@@ -3563,14 +3563,33 @@ sub process { 
						}

					}



				# , must have a space on the right.

				# , must not have a space before and must have a space on the right.

				} elsif ($op eq ',') {

					my $rtrim_before = 0;

					my $space_after = 0;

					if ($ctx =~ /Wx./) {

						if (ERROR("SPACING",

							  "space prohibited before that '$op' $at\n" . $hereptr)) {

							$line_fixed = 1;

							$rtrim_before = 1;

						}

					}

					if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {

						if (ERROR("SPACING",

							  "space required after that '$op' $at\n" . $hereptr)) {

							$good = $fix_elements[$n] . trim($fix_elements[$n + 1]) . " ";

							$line_fixed = 1;

							$last_after = $n;

							$space_after = 1;

						}

					}

					if ($rtrim_before || $space_after) {

						if ($rtrim_before) {

							$good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);

						} else {

							$good = $fix_elements[$n] . trim($fix_elements[$n + 1]);

						}

						if ($space_after) {

							$good .= " ";

						}

					}