Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2344b5b6 authored by David Howells's avatar David Howells Committed by Linus Torvalds
Browse files

Fix lpfc_parse_bg_err()'s use of do_div() 



Fix lpfc_parse_bg_err()'s use of do_div().  It should be passing a 64-bit
variable as the first parameter.  However, since it's only using a 32-bit
variable, it doesn't need to use do_div() at all, but can instead use the
division operator.

This deals with the following warnings:

    CC      drivers/scsi/lpfc/lpfc_scsi.o
  drivers/scsi/lpfc/lpfc_scsi.c: In function 'lpfc_parse_bg_err':
  drivers/scsi/lpfc/lpfc_scsi.c:1397: warning: comparison of distinct pointer types lacks a cast
  drivers/scsi/lpfc/lpfc_scsi.c:1397: warning: right shift count >= width of type
  drivers/scsi/lpfc/lpfc_scsi.c:1397: warning: passing argument 1 of '__div64_32' from incompatible pointer type

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 78c5b82e

drivers/scsi/lpfc/lpfc_scsi.c

+1 −1
Original line number Diff line number Diff line
@@ -1394,7 +1394,7 @@ lpfc_parse_bg_err(struct lpfc_hba *phba, struct lpfc_scsi_buf *lpfc_cmd, 
		 */

		cmd->sense_buffer[8] = 0;     /* Information */

		cmd->sense_buffer[9] = 0xa;   /* Add. length */

		do_div(bghm, cmd->device->sector_size);

		bghm /= cmd->device->sector_size;



		failing_sector = scsi_get_lba(cmd);

		failing_sector += bghm;