Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21b76f19 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Paul Moore
Browse files

selinux: use kstrdup() in security_get_bools() 



This is much simpler.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: default avatarPaul Moore <pmoore@redhat.com>
parent aa736c36

security/selinux/ss/services.c

+1 −7
Original line number Diff line number Diff line
@@ -2609,18 +2609,12 @@ int security_get_bools(int *len, char ***names, int **values) 
		goto err;



	for (i = 0; i < *len; i++) {

		size_t name_len;



		(*values)[i] = policydb.bool_val_to_struct[i]->state;

		name_len = strlen(sym_name(&policydb, SYM_BOOLS, i)) + 1;



		rc = -ENOMEM;

		(*names)[i] = kmalloc(sizeof(char) * name_len, GFP_ATOMIC);

		(*names)[i] = kstrdup(sym_name(&policydb, SYM_BOOLS, i), GFP_ATOMIC);

		if (!(*names)[i])

			goto err;



		strncpy((*names)[i], sym_name(&policydb, SYM_BOOLS, i), name_len);

		(*names)[i][name_len - 1] = 0;

	}

	rc = 0;

out: