Commit 1fc6aa96 authored Feb 02, 2015 by Nobuhiro Iwamatsu Committed by Bjorn Helgaas Feb 23, 2015

PCI: rcar: Fix position of MSI enable bit



The MSI enable is bit 31, not bit 28.  Set the correct bit to initialize
MSI.

Per Phil, "this is odd as MSI works before and after your patch. Since bit
31 just represents the value of MSICAP0[16].MSIE, I think this may just be
used for endpoints.  However, you are correct that the bit used was wrong."

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Phil Edworthy <phil.edworthy@renesas.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>

parent c517d838

drivers/pci/host/pcie-rcar.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -501,7 +501,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie)

		/* Enable MSI */
		if (IS_ENABLED(CONFIG_PCI_MSI))
		rcar_pci_write_reg(pcie, 0x101f0000, PCIEMSITXR);
		rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR);

		/* Finish initialization - establish a PCI Express link */
		rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR);