Commit 1d6c4cca authored Feb 11, 2015 by Vaishali Thakkar Committed by David S. Miller Feb 11, 2015

drivers/net: Use setup_timer and mod_timer



This patch introduces the use of functions setup_timer
and mod_timer.

This is done using Coccinelle and semantic patch used
for this as follows:

// <smpl>
@@
expression x,y,z,a,b;
@@

-init_timer (&x);
+setup_timer (&x, y, z);
+mod_timer (&a, b);
-x.function = y;
-x.data = z;
-x.expires = b;
-add_timer(&a);

// </smpl>

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 163cff31

drivers/net/ethernet/3com/3c589_cs.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -518,11 +518,8 @@ static int el3_open(struct net_device *dev)
		netif_start_queue(dev);

		tc589_reset(dev);
		init_timer(&lp->media);
		lp->media.function = media_check;
		lp->media.data = (unsigned long) dev;
		lp->media.expires = jiffies + HZ;
		add_timer(&lp->media);
		setup_timer(&lp->media, media_check, (unsigned long)dev);
		mod_timer(&lp->media, jiffies + HZ);

		dev_dbg(&link->dev, "%s: opened, status %4.4x.\n",
		dev->name, inw(dev->base_addr + EL3_STATUS));