Commit 1b69beb7 authored Aug 08, 2011 by Mark Rutland Committed by Will Deacon Aug 31, 2011

ARM: perf: remove unnecessary armpmu->stop



As armpmu_disable will call armpmu->stop when the last event has been
removed, this is pointless and simply adds to the noise when debugging.
Additionally, due to this call occurring in a preemptible context, this
is problematic for per-cpu locking of PMU registers (where we will
attempt to access per-cpu spinlock for use with raw_spin_lock_irqsave).

This patch removes the call to armpmu->stop.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Will Deacon <will.deacon@arm.com>
Reviewed-by: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>

parent 92f701e1

arch/arm/kernel/perf_event.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -396,7 +396,6 @@ armpmu_release_hardware(void)
		free_irq(irq, NULL);
		}

		armpmu->stop();
		release_pmu(ARM_PMU_DEVICE_CPU);
		}