Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b3aa7af authored by Alan Cox's avatar Alan Cox Committed by Jeff Garzik
Browse files

cxgb3: Use CAP_SYS_RAWIO for firmware 



Otherwise theoretically at least

	CAP_NET_ADMIN
	Reload new firmware
	Wait..
	Firmware patches kernel

So it should be CAY_SYS_RAWIO - not that I suspect this is in fact a
credible attack vector!

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 01935d7d

drivers/net/cxgb3/cxgb3_main.c

+2 −2
Original line number Diff line number Diff line
@@ -1894,11 +1894,11 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr) 
		u8 *fw_data;

		struct ch_mem_range t;



		if (!capable(CAP_NET_ADMIN))

		if (!capable(CAP_SYS_RAWIO))

			return -EPERM;

		if (copy_from_user(&t, useraddr, sizeof(t)))

			return -EFAULT;



		/* Check t.len sanity ? */

		fw_data = kmalloc(t.len, GFP_KERNEL);

		if (!fw_data)

			return -ENOMEM;