Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a5d39d0 authored by Alan Cox's avatar Alan Cox Committed by Mark Brown
Browse files

regulator: tps65217: invalid if check 



This permits the setting of bogus values because the invalidity check is
itself invalid.

Reported-by: default avatar <dcb314@hotmail.com>
Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 1e12dfc9

drivers/regulator/tps65217-regulator.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -78,7 +78,7 @@ static int tps65217_vsel_to_uv1(unsigned int vsel) 




static int tps65217_uv_to_vsel1(int uV, unsigned int *vsel)

static int tps65217_uv_to_vsel1(int uV, unsigned int *vsel)

{

{

	if ((uV < 0) && (uV > 3300000))

	if (uV < 0 || uV > 3300000)

		return -EINVAL;

		return -EINVAL;





	if (uV <= 1500000)

	if (uV <= 1500000)
@@ -112,7 +112,7 @@ static int tps65217_vsel_to_uv2(unsigned int vsel) 




static int tps65217_uv_to_vsel2(int uV, unsigned int *vsel)

static int tps65217_uv_to_vsel2(int uV, unsigned int *vsel)

{

{

	if ((uV < 0) && (uV > 3300000))

	if (uV < 0 || uV > 3300000)

		return -EINVAL;

		return -EINVAL;





	if (uV <= 1900000)

	if (uV <= 1900000)