Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a34456b authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by James Bottomley
Browse files

[SCSI] Overrun in drivers/scsi/sim710.c 



This fixes coverity bug id #480.  Since id_array is declared as
id_array[MAX_SLOTS], the check for i>MAX_SLOTS is obviously false.

Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 36ab2618

drivers/scsi/sim710.c

+1 −1
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ param_setup(char *str) 
		else if(!strncmp(pos, "id:", 3)) {

			if(slot == -1) {

				printk(KERN_WARNING "sim710: Must specify slot for id parameter\n");

			} else if(slot > MAX_SLOTS) {

			} else if(slot >= MAX_SLOTS) {

				printk(KERN_WARNING "sim710: Illegal slot %d for id %d\n", slot, val);

			} else {

				id_array[slot] = val;