Commit 19c5392e authored Jan 27, 2015 by Lucas Stach Committed by Bjorn Helgaas Jan 27, 2015

PCI: designware: Reject MSI-X IRQs



The DesignWare PCIe MSI hardware does not support MSI-X IRQs.  Setting
those up failed as a side effect of a bug which was fixed by 91f8ae82
("PCI: designware: Setup and clear exactly one MSI at a time").

Now that this bug is fixed, MSI-X IRQs need to be rejected explicitly;
otherwise devices trying to use them may end up with incorrectly working
interrupts.

Fixes: 91f8ae82 ("PCI: designware: Setup and clear exactly one MSI at a time")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
CC: stable@vger.kernel.org	# v3.18+

parent f175aa2c

drivers/pci/host/pcie-designware.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -283,6 +283,9 @@ static int dw_msi_setup_irq(struct msi_controller chip, struct pci_dev pdev,
		struct msi_msg msg;
		struct pcie_port *pp = sys_to_pcie(pdev->bus->sysdata);

		if (desc->msi_attrib.is_msix)
		return -EINVAL;

		irq = assign_irq(1, desc, &pos);
		if (irq < 0)
		return irq;