Commit 19b73d8e authored Mar 10, 2016 by Mitch Williams Committed by Jeff Kirsher Apr 05, 2016

i40evf: Add additional check for reset



If the driver happens to read a register during the time in which the
device is undergoing reset, it will receive a value of 0xdeadbeef
instead of a valid value. Unfortunately, the driver may misinterpret
this as a valid value, especially if it's just looking for individual
bits.

Add an explicit check for this value when we are looking for admin queue
errors, and trigger reset recovery if we find it.

Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 56e5ca68

drivers/net/ethernet/intel/i40evf/i40evf_main.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1994,6 +1994,8 @@ static void i40evf_adminq_task(struct work_struct *work)

		/* check for error indications */
		val = rd32(hw, hw->aq.arq.len);
		if (val == 0xdeadbeef) /* indicates device in reset */
		goto freedom;
		oldval = val;
		if (val & I40E_VF_ARQLEN1_ARQVFE_MASK) {
		dev_info(&adapter->pdev->dev, "ARQ VF Error detected\n");