Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19a93f04 authored by Dave Airlie's avatar Dave Airlie
Browse files

drm/dp: retry AUX transactions 32 times (v1.1) 



At least on two MST devices I've tested with, when
they are link training downstream, they are totally
unable to handle aux ch msgs, so they defer like nuts.
I tried 16, it wasn't enough, 32 seems better.

This fixes one Dell 4k monitor and one of the
MST hubs.

v1.1: fixup comment (Tom).

Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent b75478d1

drivers/gpu/drm/drm_dp_helper.c

+4 −3
Original line number Diff line number Diff line
@@ -186,10 +186,11 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, 


	/*

	 * The specification doesn't give any recommendation on how often to

	 * retry native transactions, so retry 7 times like for I2C-over-AUX

	 * transactions.

	 * retry native transactions. We used to retry 7 times like for

	 * aux i2c transactions but real world devices this wasn't

	 * sufficient, bump to 32 which makes Dell 4k monitors happier.

	 */

	for (retry = 0; retry < 7; retry++) {

	for (retry = 0; retry < 32; retry++) {



		mutex_lock(&aux->hw_mutex);

		err = aux->transfer(aux, &msg);