Commit 19443178 authored May 05, 2008 by Chris Wright Committed by David S. Miller May 05, 2008

dccp: return -EINVAL on invalid feature length



dccp_feat_change() validates length and on error is returning 1.
This happens to work since call chain is checking for 0 == success,
but this is returned to userspace, so make it a real error value.

Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7a1aa309

net/dccp/feat.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -32,7 +32,7 @@ int dccp_feat_change(struct dccp_minisock *dmsk, u8 type, u8 feature,

		if (len > 3) {
		DCCP_WARN("invalid length %d\n", len);
		return 1;
		return -EINVAL;
		}
		/* XXX add further sanity checks */