Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18b429e7 authored by Philip A. Prindeville's avatar Philip A. Prindeville Committed by David S. Miller
Browse files

atm/solos-pci: Don't include frame pseudo-header on transmit hex-dump 



Omit pkt_hdr preamble when dumping transmitted packet as hex-dump;
we can pull this up because the frame has already been sent, and
dumping it is the last thing we do with it before freeing it.

Also include the size, vpi, and vci in the debug as is done on
receive.

Use "port" consistently instead of "device" intermittently.

Signed-off-by: default avatarPhilip Prindeville <philipp@redfish-solutions.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1e19e658

drivers/atm/solos-pci.c

+8 −1
Original line number Diff line number Diff line
@@ -697,7 +697,7 @@ void solos_bh(unsigned long card_arg) 
					      size);

			}

			if (atmdebug) {

				dev_info(&card->dev->dev, "Received: device %d\n", port);

				dev_info(&card->dev->dev, "Received: port %d\n", port);

				dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",

					 size, le16_to_cpu(header->vpi),

					 le16_to_cpu(header->vci));
@@ -1018,8 +1018,15 @@ static uint32_t fpga_tx(struct solos_card *card) 


			/* Clean up and free oldskb now it's gone */

			if (atmdebug) {

				struct pkt_hdr *header = (void *)oldskb->data;

				int size = le16_to_cpu(header->size);



				skb_pull(oldskb, sizeof(*header));

				dev_info(&card->dev->dev, "Transmitted: port %d\n",

					 port);

				dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",

					 size, le16_to_cpu(header->vpi),

					 le16_to_cpu(header->vci));

				print_buffer(oldskb);

			}