Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 186ecebe authored by NeilBrown's avatar NeilBrown Committed by Kishon Vijay Abraham I
Browse files

phy: twl4030-usb: remove pointless 'suspended' test in 'suspend' callback. 



When the runtime_suspend callback is running, 'runtime_status'
is always RPM_SUSPENDING, so pm_runtime_suspended() will always
fail.
Similarly while the runtime_resume callback is running
'runtime_status' is RPM_RESUMING, so pm_runtime_active() will
always fail.

So remove these two pointless tests.

Signed-off-by: default avatarNeilBrown <neil@brown.name>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent 56301df6

drivers/phy/phy-twl4030-usb.c

+0 −4
Original line number Original line Diff line number Diff line
@@ -396,8 +396,6 @@ static int twl4030_usb_runtime_suspend(struct device *dev) 
	struct twl4030_usb *twl = dev_get_drvdata(dev);

	struct twl4030_usb *twl = dev_get_drvdata(dev);





	dev_dbg(twl->dev, "%s\n", __func__);

	dev_dbg(twl->dev, "%s\n", __func__);

	if (pm_runtime_suspended(dev))

		return 0;





	__twl4030_phy_power(twl, 0);

	__twl4030_phy_power(twl, 0);

	regulator_disable(twl->usb1v5);

	regulator_disable(twl->usb1v5);
@@ -413,8 +411,6 @@ static int twl4030_usb_runtime_resume(struct device *dev) 
	int res;

	int res;





	dev_dbg(twl->dev, "%s\n", __func__);

	dev_dbg(twl->dev, "%s\n", __func__);

	if (pm_runtime_active(dev))

		return 0;





	res = regulator_enable(twl->usb3v1);

	res = regulator_enable(twl->usb3v1);

	if (res)

	if (res)