Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 184b57c6 authored by Mike Christie's avatar Mike Christie Committed by James Bottomley
Browse files

[SCSI] libiscsi: check of LLD has a alloc pdu callout. 



bnx2i does not have one. It currently preallocates the bdt
when the session is setup.

We probably want to change that to a dma pool, then allocate from
the pool in the alloc pdu. Until then check if there is a alloc
pdu callout.

Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 10eb0f01

drivers/scsi/libiscsi.c

+12 −7
Original line number Diff line number Diff line
@@ -257,9 +257,11 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task *task) 
	itt_t itt;

	int rc;



	if (conn->session->tt->alloc_pdu) {

		rc = conn->session->tt->alloc_pdu(task, ISCSI_OP_SCSI_CMD);

		if (rc)

			return rc;

	}

	hdr = (struct iscsi_cmd *) task->hdr;

	itt = hdr->itt;

	memset(hdr, 0, sizeof(*hdr));
@@ -566,11 +568,14 @@ __iscsi_conn_send_pdu(struct iscsi_conn *conn, struct iscsi_hdr *hdr, 
	} else

		task->data_count = 0;



	if (conn->session->tt->alloc_pdu) {

		if (conn->session->tt->alloc_pdu(task, hdr->opcode)) {

			iscsi_conn_printk(KERN_ERR, conn, "Could not allocate "

					 "pdu for mgmt task.\n");

			goto requeue_task;

		}

	}



	itt = task->hdr->itt;

	task->hdr_len = sizeof(struct iscsi_hdr);

	memcpy(task->hdr, hdr, sizeof(struct iscsi_hdr));