Commit 17fb874d authored Jul 24, 2015 by Martin Schwidefsky Committed by Herbert Xu Jul 28, 2015

hwrng: core - correct error check of kthread_run call



The kthread_run() function can return two different error values
but the hwrng core only checks for -ENOMEM. If the other error
value -EINTR is returned it is assigned to hwrng_fill and later
used on a kthread_stop() call which naturally crashes.

Cc: stable@vger.kernel.org
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent f898c522

drivers/char/hw_random/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -429,7 +429,7 @@ static int hwrng_fillfn(void *unused)
		static void start_khwrngd(void)
		{
		hwrng_fill = kthread_run(hwrng_fillfn, NULL, "hwrng");
		if (hwrng_fill == ERR_PTR(-ENOMEM)) {
		if (IS_ERR(hwrng_fill)) {
		pr_err("hwrng_fill thread creation failed");
		hwrng_fill = NULL;
		}