Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1783e4bf authored by Thomas Renninger's avatar Thomas Renninger Committed by Dave Airlie
Browse files

drm radeon: Return -EINVAL on wrong pm sysfs access 



Throw an error if someone tries to fill this with
wrong data, instead of simply ignoring the input.
Now you get:

echo hello >/sys/../power_method
-bash: echo: write error: Invalid argument

Signed-off-by: default avatarThomas Renninger <trenn@suse.de>
CC: Alexander.Deucher@amd.com
CC: dri-devel@lists.freedesktop.org
Reviewed-by: default avatarAlex Deucher <alexdeucher@gmail.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent fafcf94e

drivers/gpu/drm/radeon/radeon_pm.c

+5 −3
Original line number Diff line number Diff line
@@ -365,12 +365,14 @@ static ssize_t radeon_set_pm_profile(struct device *dev, 
		else if (strncmp("high", buf, strlen("high")) == 0)

			rdev->pm.profile = PM_PROFILE_HIGH;

		else {

			DRM_ERROR("invalid power profile!\n");

			count = -EINVAL;

			goto fail;

		}

		radeon_pm_update_profile(rdev);

		radeon_pm_set_clocks(rdev);

	}

	} else

		count = -EINVAL;



fail:

	mutex_unlock(&rdev->pm.mutex);
@@ -413,7 +415,7 @@ static ssize_t radeon_set_pm_method(struct device *dev, 
		mutex_unlock(&rdev->pm.mutex);

		cancel_delayed_work_sync(&rdev->pm.dynpm_idle_work);

	} else {

		DRM_ERROR("invalid power method!\n");

		count = -EINVAL;

		goto fail;

	}

	radeon_pm_compute_clocks(rdev);