Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 16d56963 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Herbert Xu
Browse files

crypto: rockchip - use devm_add_action_or_reset() 



If devm_add_action() fails we are explicitly calling the cleanup to free
the resources allocated.  Lets use the helper devm_add_action_or_reset()
and return directly in case of error, as we know that the cleanup function
has been already called by the helper if there was any error.

Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent e09287df

drivers/crypto/rockchip/rk3288_crypto.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -304,11 +304,9 @@ static int rk_crypto_probe(struct platform_device *pdev) 
	usleep_range(10, 20);

	usleep_range(10, 20);

	reset_control_deassert(crypto_info->rst);

	reset_control_deassert(crypto_info->rst);





	err = devm_add_action(dev, rk_crypto_action, crypto_info);

	err = devm_add_action_or_reset(dev, rk_crypto_action, crypto_info);

	if (err) {

	if (err)

		reset_control_assert(crypto_info->rst);

		goto err_crypto;

		goto err_crypto;

	}





	spin_lock_init(&crypto_info->lock);

	spin_lock_init(&crypto_info->lock);