Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 16be63fd authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

bluetooth: remove improper bluetooth class symlinks. 



Don't create symlinks in a class to a device that is not owned by the
class.  If the bluetooth subsystem really wants to point to all of the
devices it controls, it needs to create real devices, not fake symlinks.

Cc: Maxim Krasnyansky <maxk@qualcomm.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Acked-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 110cf374

net/bluetooth/hci_sysfs.c

+0 −7
Original line number Diff line number Diff line
@@ -398,10 +398,6 @@ int hci_register_sysfs(struct hci_dev *hdev) 
		if (device_create_file(dev, bt_attrs[i]) < 0)

			BT_ERR("Failed to create device attribute");



	if (sysfs_create_link(&bt_class->subsys.kobj,

				&dev->kobj, kobject_name(&dev->kobj)) < 0)

		BT_ERR("Failed to create class symlink");



	return 0;

}
@@ -409,9 +405,6 @@ void hci_unregister_sysfs(struct hci_dev *hdev) 
{

	BT_DBG("%p name %s type %d", hdev, hdev->name, hdev->type);



	sysfs_remove_link(&bt_class->subsys.kobj,

					kobject_name(&hdev->dev.kobj));



	device_del(&hdev->dev);

}