Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15da7808 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Yao
Browse files

drm/rockchip: fix a couple off by one bugs 



The priv->crtc_funcs[] array has ROCKCHIP_MAX_CRTC elements so > should
be >= here.

Fixes: 2048e328 ('drm: rockchip: Add basic drm driver')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
parent 44958207

drivers/gpu/drm/rockchip/rockchip_drm_drv.c

+2 −2
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ int rockchip_register_crtc_funcs(struct drm_crtc *crtc, 
	int pipe = drm_crtc_index(crtc);

	struct rockchip_drm_private *priv = crtc->dev->dev_private;



	if (pipe > ROCKCHIP_MAX_CRTC)

	if (pipe >= ROCKCHIP_MAX_CRTC)

		return -EINVAL;



	priv->crtc_funcs[pipe] = crtc_funcs;
@@ -92,7 +92,7 @@ void rockchip_unregister_crtc_funcs(struct drm_crtc *crtc) 
	int pipe = drm_crtc_index(crtc);

	struct rockchip_drm_private *priv = crtc->dev->dev_private;



	if (pipe > ROCKCHIP_MAX_CRTC)

	if (pipe >= ROCKCHIP_MAX_CRTC)

		return;



	priv->crtc_funcs[pipe] = NULL;