Commit 15411c27 authored Jan 24, 2011 by Bob Copeland Committed by John W. Linville Jan 27, 2011

ath5k: fix error handling in ath5k_hw_dma_stop



Review spotted a problem with the error handling in ath5k_hw_dma_stop:
a successful return from ath5k_hw_stop_tx_dma will be treated as
an error, so we always bail out of the loop after processing a single
active queue.  As a result, we may not actually stop some queues during
reset.

Signed-off-by: Bob Copeland <me@bobcopeland.com>
Acked-by: Bruno Randolf <br1@einfach.org>
Acked-by: Nick Kossifidis <mickflemm@gmail.com>
Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent bc5892c9

drivers/net/wireless/ath/ath5k/dma.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -838,9 +838,9 @@ int ath5k_hw_dma_stop(struct ath5k_hw *ah)
		for (i = 0; i < qmax; i++) {
		err = ath5k_hw_stop_tx_dma(ah, i);
		/* -EINVAL -> queue inactive */
		if (err != -EINVAL)
		if (err && err != -EINVAL)
		return err;
		}

		return err;
		return 0;
		}