Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14d9cb5f authored by Chandra Seetharaman's avatar Chandra Seetharaman Committed by James Bottomley
Browse files

[SCSI] scsi_dh: Provide set_params interface in emc device handler 



Handle the parameters provided by user thru multipath.

This handler expects only 2 parameters and their value can either be 0 or 1.

This code originates from the old dm-emc.c file. Appropriate changes have
been made to make it work in the new design.

Reported-by: default avatarEddie Williams <Eddie.Williams@steeleye.com>
Signed-off-by: default avatarChandra Seetharaman <sekharan@us.ibm.com>
Tested-by: default avatarEddie Williams <Eddie.Williams@steeleye.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 18ee70c9

drivers/scsi/device_handler/scsi_dh_emc.c

+56 −3
Original line number Diff line number Diff line
@@ -561,6 +561,61 @@ static int clariion_activate(struct scsi_device *sdev) 


	return result;

}

/*

 * params - parameters in the following format

 *      "no_of_params\0param1\0param2\0param3\0...\0"

 *      for example, string for 2 parameters with value 10 and 21

 *      is specified as "2\010\021\0".

 */

static int clariion_set_params(struct scsi_device *sdev, const char *params)

{

	struct clariion_dh_data *csdev = get_clariion_data(sdev);

	unsigned int hr = 0, st = 0, argc;

	const char *p = params;

	int result = SCSI_DH_OK;



	if ((sscanf(params, "%u", &argc) != 1) || (argc != 2))

		return -EINVAL;



	while (*p++)

		;

	if ((sscanf(p, "%u", &st) != 1) || (st > 1))

		return -EINVAL;



	while (*p++)

		;

	if ((sscanf(p, "%u", &hr) != 1) || (hr > 1))

		return -EINVAL;



	if (st)

		csdev->flags |= CLARIION_SHORT_TRESPASS;

	else

		csdev->flags &= ~CLARIION_SHORT_TRESPASS;



	if (hr)

		csdev->flags |= CLARIION_HONOR_RESERVATIONS;

	else

		csdev->flags &= ~CLARIION_HONOR_RESERVATIONS;



	/*

	 * If this path is owned, we have to send a trespass command

	 * with the new parameters. If not, simply return. Next trespass

	 * command would use the parameters.

	 */

	if (csdev->lun_state != CLARIION_LUN_OWNED)

		goto done;



	csdev->lun_state = CLARIION_LUN_UNINITIALIZED;

	result = send_trespass_cmd(sdev, csdev);

	if (result != SCSI_DH_OK)

		goto done;



	/* Update status */

	result = clariion_send_inquiry(sdev, csdev);



done:

	return result;

}



static const struct scsi_dh_devlist clariion_dev_list[] = {

	{"DGC", "RAID"},
@@ -581,11 +636,9 @@ static struct scsi_device_handler clariion_dh = { 
	.check_sense	= clariion_check_sense,

	.activate	= clariion_activate,

	.prep_fn	= clariion_prep_fn,

	.set_params	= clariion_set_params,

};



/*

 * TODO: need some interface so we can set trespass values

 */

static int clariion_bus_attach(struct scsi_device *sdev)

{

	struct scsi_dh_data *scsi_dh_data;