Commit 146ea835 authored Oct 08, 2014 by Esra Altintas Committed by Greg Kroah-Hartman Oct 20, 2014

staging: speakup: Use time_after_eq to compare jiffies in speakup_keypc.c



The following patch fixes the checkpatch.pl warning:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends

Signed-off-by: Esra Altintas <es.altintas@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ad96f37f

drivers/staging/speakup/speakup_keypc.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -229,7 +229,7 @@ spin_lock_irqsave(&speakup_info.spinlock, flags);
	ch = PROCSPEECH;		ch = PROCSPEECH;
	outb_p(ch, synth_port);		outb_p(ch, synth_port);
	SWAIT;		SWAIT;
	if ((jiffies >= jiff_max) && (ch == SPACE)) {		if (time_after_eq(jiffies, jiff_max) && (ch == SPACE)) {
	timeout = 1000;		timeout = 1000;
	while (synth_writable())		while (synth_writable())
	if (--timeout <= 0)		if (--timeout <= 0)