Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13101602 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by David S. Miller
Browse files

openvswitch: Add missing initialization in validate_and_copy_set_tun() 



net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’:
net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function

If ipv4_tun_from_nlattr() returns a different positive value than
OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and
validate_and_copy_set_tun() may return an undefined value instead of a
zero success indicator. Initialize err to zero to fix this.

Fixes: 1dd144cf ("openvswitch: Support VXLAN Group Policy extension")
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Acked-by: default avatarThomas Graf <tgraf@suug.ch>
Acked-by: default avatarPravin B Shelar <pshelar@nicira.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b35725a2

net/openvswitch/flow_netlink.c

+1 −1
Original line number Diff line number Diff line
@@ -1746,7 +1746,7 @@ static int validate_and_copy_set_tun(const struct nlattr *attr, 
	struct sw_flow_key key;

	struct ovs_tunnel_info *tun_info;

	struct nlattr *a;

	int err, start, opts_type;

	int err = 0, start, opts_type;



	ovs_match_init(&match, &key, NULL);

	opts_type = ipv4_tun_from_nlattr(nla_data(attr), &match, false, log);