Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12660138 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jonathan Cameron
Browse files

iio:gyro: adis16136: divide by zero in write_frequency() 



It's slightly cleaner to use kstrtouint() because we pass unsigned ints
to adis16136_set_freq().  On 64 bit systems, if the user passed LONG_MIN
then it we would get past the test against zero but crash in
adis16136_set_freq() because we truncate the high bits away.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-By: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent bc0a409c

drivers/iio/gyro/adis16136.c

+2 −2
Original line number Diff line number Diff line
@@ -203,10 +203,10 @@ static ssize_t adis16136_write_frequency(struct device *dev, 
{

	struct iio_dev *indio_dev = dev_to_iio_dev(dev);

	struct adis16136 *adis16136 = iio_priv(indio_dev);

	long val;

	unsigned int val;

	int ret;



	ret = kstrtol(buf, 10, &val);

	ret = kstrtouint(buf, 10, &val);

	if (ret)

		return ret;