Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 120e9a45 authored by Avi Kivity's avatar Avi Kivity
Browse files

KVM: Fix adding an smp virtual machine to the vm list 



If we add the vm once per vcpu, we corrupt the list if the guest has
multiple vcpus.

Signed-off-by: default avatarAvi Kivity <avi@qumranet.com>
parent 7b53aa56

drivers/kvm/kvm_main.c

+3 −3
Original line number Diff line number Diff line
@@ -319,6 +319,9 @@ static struct kvm *kvm_create_vm(void) 


	spin_lock_init(&kvm->lock);

	INIT_LIST_HEAD(&kvm->active_mmu_pages);

	spin_lock(&kvm_lock);

	list_add(&kvm->vm_list, &vm_list);

	spin_unlock(&kvm_lock);

	for (i = 0; i < KVM_MAX_VCPUS; ++i) {

		struct kvm_vcpu *vcpu = &kvm->vcpus[i];
@@ -326,9 +329,6 @@ static struct kvm *kvm_create_vm(void) 
		vcpu->cpu = -1;

		vcpu->kvm = kvm;

		vcpu->mmu.root_hpa = INVALID_PAGE;

		spin_lock(&kvm_lock);

		list_add(&kvm->vm_list, &vm_list);

		spin_unlock(&kvm_lock);

	}

	return kvm;

}