Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1207cf84 authored by Jesper Juhl's avatar Jesper Juhl Committed by Greg Kroah-Hartman
Browse files

USB: Fix a memory leak in em28xx_usb_probe() 



If, in em28xx_usb_probe() the memory allocation
	dev->alt_max_pkt_size = kmalloc(32*
						dev->num_alt,GFP_KERNEL);
fails, then we'll bail out and return -ENOMEM.
The problem is that in that case we don't free the storage allocated
to 'dev', thus causing a memory leak.

This patch fixes the leak by freeing 'dev' before we return -ENOMEM.
This fixes Coverity bug #647.


Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent e48eb085

drivers/media/video/em28xx/em28xx-video.c

+1 −0
Original line number Diff line number Diff line
@@ -1772,6 +1772,7 @@ static int em28xx_usb_probe(struct usb_interface *interface, 
	if (dev->alt_max_pkt_size == NULL) {

		em28xx_errdev("out of memory!\n");

		em28xx_devused&=~(1<<nr);

		kfree(dev);

		return -ENOMEM;

	}