Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 11432050 authored by Kazuya Mizuguchi's avatar Kazuya Mizuguchi Committed by Felipe Balbi
Browse files

usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable() 



This patch fixes an issue that the NULL pointer dereference happens
when we uses g_audio driver. Since the g_audio driver will call
usb_ep_disable() in afunc_set_alt() before it calls usb_ep_enable(),
the uep->pipe of renesas usbhs driver will be NULL. So, this patch
adds a condition to avoid the oops.

Signed-off-by: default avatarKazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: default avatarTakeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Fixes: 2f98382d (usb: renesas_usbhs: Add Renesas USBHS Gadget)
Cc: <stable@vger.kernel.org> # v3.0+
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent c3761a79

drivers/usb/renesas_usbhs/mod_gadget.c

+3 −0
Original line number Diff line number Diff line
@@ -602,6 +602,9 @@ static int usbhsg_ep_disable(struct usb_ep *ep) 
	struct usbhsg_uep *uep = usbhsg_ep_to_uep(ep);

	struct usbhs_pipe *pipe = usbhsg_uep_to_pipe(uep);



	if (!pipe)

		return -EINVAL;



	usbhsg_pipe_disable(uep);

	usbhs_pipe_free(pipe);