Commit 1101d586 authored Feb 12, 2013 by Tim Gardner Committed by Tyler Hicks Feb 12, 2013

ecryptfs: ecryptfs_msg_ctx_alloc_to_free(): remove kfree() redundant null check



smatch analysis:

fs/ecryptfs/messaging.c:101 ecryptfs_msg_ctx_alloc_to_free() info:
 redundant null check on msg_ctx->msg calling kfree()

Cc: Dustin Kirkland <dustin.kirkland@gazzang.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>

parent 3a467418

fs/ecryptfs/messaging.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -97,7 +97,6 @@ static void ecryptfs_msg_ctx_free_to_alloc(struct ecryptfs_msg_ctx *msg_ctx)
		void ecryptfs_msg_ctx_alloc_to_free(struct ecryptfs_msg_ctx *msg_ctx)
		{
		list_move(&(msg_ctx->node), &ecryptfs_msg_ctx_free_list);
		if (msg_ctx->msg)
		kfree(msg_ctx->msg);
		msg_ctx->msg = NULL;
		msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_FREE;