Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 104a32e8 authored by Wei Yongjun's avatar Wei Yongjun Committed by Herbert Xu
Browse files

hwrng: geode - fix return value check in mod_init() 



In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: 6e9b5e76 ("hwrng: geode - Migrate to managed API")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f7eca278

drivers/char/hw_random/geode-rng.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -95,8 +95,8 @@ static int __init mod_init(void) 
				return -ENODEV;

				return -ENODEV;





			mem = devm_ioremap(&pdev->dev, rng_base, 0x58);

			mem = devm_ioremap(&pdev->dev, rng_base, 0x58);

			if (IS_ERR(mem))

			if (!mem)

				return PTR_ERR(mem);

				return -ENOMEM;

			geode_rng.priv = (unsigned long)mem;

			geode_rng.priv = (unsigned long)mem;





			pr_info("AMD Geode RNG detected\n");

			pr_info("AMD Geode RNG detected\n");