Commit 102a1a20 authored Oct 16, 2007 by Maciej W. Rozycki Committed by Linus Torvalds Oct 16, 2007

tgafb: remove a redundant non-mono test in mono imageblit



There is a test in tgafb_mono_imageblit() for a colour image with a fall-back
to cfb_imageblit().  The test is not necessary as the only caller, which is
tgafb_imageblit(), checks it too and only invokes this function for monochrome
images.  It looks like a left-over from before some changes to
tgafb_imageblit().

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Cc: Antonino Daplas <adaplas@pol.net>
Cc: Jay Estabrook <Jay.Estabrook@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent b738b990

drivers/video/tgafb.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -637,15 +637,6 @@ tgafb_mono_imageblit(struct fb_info info, const struct fb_image image)

		is8bpp = info->var.bits_per_pixel == 8;

		/* For copies that aren't pixel expansion, there's little we
		can do better than the generic code. */
		/* ??? There is a DMA write mode; I wonder if that could be
		made to pull the data from the image buffer... */
		if (image->depth > 1) {
		cfb_imageblit(info, image);
		return;
		}

		dx = image->dx;
		dy = image->dy;
		width = image->width;