Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f8fdab1 authored by Emil Tantilov's avatar Emil Tantilov Committed by Jeff Kirsher
Browse files

ixgbe: fix ethtool reporting of supported links for SFP modules 



This patch resolves an issue where the driver will display incorrect info
for Q/SFP+ modules that were inserted after the driver has been loaded.

This patch adds a call to identify_phy() in ixgbe_get_settings() prior to
calling get_link_capabilities() which needs the PHY data in order to
determine the correct settings.

Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Tested-by: default avatarPhil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent ed33ff66

drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c

+7 −0
Original line number Diff line number Diff line
@@ -160,6 +160,13 @@ static int ixgbe_get_settings(struct net_device *netdev, 
	bool autoneg = false;

	bool link_up;



	/* SFP type is needed for get_link_capabilities */

	if (hw->phy.media_type & (ixgbe_media_type_fiber |

				  ixgbe_media_type_fiber_qsfp)) {

		if (hw->phy.sfp_type == ixgbe_sfp_type_not_present)

				hw->phy.ops.identify_sfp(hw);

	}



	hw->mac.ops.get_link_capabilities(hw, &supported_link, &autoneg);



	/* set the supported link speeds */