Commit 0f3696eb authored Jan 09, 2012 by Julia Lawall Committed by Roland Dreier Jan 27, 2012

IB/qib: Use GFP_ATOMIC when locks are held



alloc_dummy_hdrq() is called with locks held and thus should not use
GFP_KERNEL.

The semantic patch that makes this report is available in
scripts/coccinelle/locks/call_kern.cocci.

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by: Mike Marciniszyn <mike.marciniszyn@qlogic.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>

parent dcd6c922

drivers/infiniband/hw/qib/qib_iba6120.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2105,7 +2105,7 @@ static void alloc_dummy_hdrq(struct qib_devdata *dd)
		dd->cspec->dummy_hdrq = dma_alloc_coherent(&dd->pcidev->dev,
		dd->rcd[0]->rcvhdrq_size,
		&dd->cspec->dummy_hdrq_phys,
		GFP_KERNEL \| __GFP_COMP);
		GFP_ATOMIC \| __GFP_COMP);
		if (!dd->cspec->dummy_hdrq) {
		qib_devinfo(dd->pcidev, "Couldn't allocate dummy hdrq\n");
		/* fallback to just 0'ing */