Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e5537b3 authored by Sivaram Nair's avatar Sivaram Nair Committed by Rafael J. Wysocki
Browse files

cpuidle: Fix finding state with min power_usage 



Since cpuidle_state.power_usage is a signed value, use INT_MAX (instead
of -1) to init the local copies so that functions that tries to find
cpuidle states with minimum power usage works correctly even if they use
non-negative values.

Signed-off-by: default avatarSivaram Nair <sivaramn@nvidia.com>
Reviewed-by: default avatarRik van Riel <riel@redhat.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent d1c3ed66

drivers/cpuidle/cpuidle.c

+1 −1
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ int cpuidle_play_dead(void) 
	struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);

	struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);

	int i, dead_state = -1;

	int power_usage = -1;

	int power_usage = INT_MAX;



	if (!drv)

		return -ENODEV;

drivers/cpuidle/governors/menu.c

+1 −1
Original line number Diff line number Diff line
@@ -312,7 +312,7 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) 
{

	struct menu_device *data = &__get_cpu_var(menu_devices);

	int latency_req = pm_qos_request(PM_QOS_CPU_DMA_LATENCY);

	int power_usage = -1;

	int power_usage = INT_MAX;

	int i;

	int multiplier;

	struct timespec t;