Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e28bf93 authored by Anna-Maria Gleixner's avatar Anna-Maria Gleixner Committed by David S. Miller
Browse files

net: mvneta: Remove superfluous SMP function call 



Since commit 3b9d6da6 ("cpu/hotplug: Fix rollback during error-out
in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
function calls are no longer required.

Replace smp_call_function_single() with a direct call to
mvneta_percpu_enable() or mvneta_percpu_disable(). The functions do
not require to be called with interrupts disabled, therefore the
smp_call_function_single() calling convention is not preserved.

Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarAnna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ce24c2b8

drivers/net/ethernet/marvell/mvneta.c

+2 −4
Original line number Diff line number Diff line
@@ -3354,8 +3354,7 @@ static int mvneta_percpu_notifier(struct notifier_block *nfb, 
		/* Enable per-CPU interrupts on the CPU that is

		 * brought up.

		 */

		smp_call_function_single(cpu, mvneta_percpu_enable,

					 pp, true);

		mvneta_percpu_enable(pp);



		/* Enable per-CPU interrupt on the one CPU we care

		 * about.
@@ -3387,8 +3386,7 @@ static int mvneta_percpu_notifier(struct notifier_block *nfb, 
		/* Disable per-CPU interrupts on the CPU that is

		 * brought down.

		 */

		smp_call_function_single(cpu, mvneta_percpu_disable,

					 pp, true);

		mvneta_percpu_disable(pp);



		break;

	case CPU_DEAD: