Commit 0df49b91 authored Nov 12, 2008 by yanhai zhu Committed by Chris Mason Nov 12, 2008

Btrfs: Check kthread_should_stop() before schedule() in worker_loop

In worker_loop(), the func should check whether it has been requested to stop
before it decides to schedule out.

Otherwise if the stop request(also the last wake_up()) sent by
btrfs_stop_workers() happens when worker_loop() running after the "while"
judgement and before schedule(), woker_loop() will schedule away and never be
woken up, which will also cause btrfs_stop_workers() wait forever.

Signed-off-by: Chris Mason <chris.mason@oracle.com>

parent c36047d7

fs/btrfs/async-thread.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -171,6 +171,7 @@ static int worker_loop(void *arg)
		} else {
		set_current_state(TASK_INTERRUPTIBLE);
		spin_unlock_irq(&worker->lock);
		if (!kthread_should_stop())
		schedule();
		__set_current_state(TASK_RUNNING);
		}