Commit 0df1e4f5 authored Oct 11, 2016 by Keith Busch Committed by Jens Axboe Oct 12, 2016

nvme: Stop probing a removed device



There is no reason the nvme controller can ever return all 1's from
reading the CSTS register. This patch returns an error if we observe
that status. Without this, we may incorrectly proceed with controller
initialization and unnecessarilly rely on error handling to clean this.

Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 1fa9ce8d

drivers/nvme/host/core.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1086,6 +1086,8 @@ static int nvme_wait_ready(struct nvme_ctrl *ctrl, u64 cap, bool enabled)
		int ret;

		while ((ret = ctrl->ops->reg_read32(ctrl, NVME_REG_CSTS, &csts)) == 0) {
		if (csts == ~0)
		return -ENODEV;
		if ((csts & NVME_CSTS_RDY) == bit)
		break;