Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0dc6c490 authored by Ben Dooks's avatar Ben Dooks
Browse files

[ARM] footbridge: dc21285.c warning fixes 



The dc21285 requests a number of IRQs that it doesn't really
care whether they get added. Change to use a macro that ensures
that at-least the user gets warned if they fail to add, which
also stops the warnings from __unused_result on request_irq().

dc21285.c:337: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result
dc21285.c:339: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result
dc21285.c:341: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result
dc21285.c:343: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result
dc21285.c:345: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result

Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
parent 39ebfd3f

arch/arm/mach-footbridge/dc21285.c

+13 −10
Original line number Diff line number Diff line
@@ -287,6 +287,9 @@ struct pci_bus * __init dc21285_scan_bus(int nr, struct pci_sys_data *sys) 
	return pci_scan_bus(0, &dc21285_ops, sys);

}



#define dc21285_request_irq(_a, _b, _c, _d, _e) \

	WARN_ON(request_irq(_a, _b, _c, _d, _e) < 0)



void __init dc21285_preinit(void)

{

	unsigned int mem_size, mem_mask;
@@ -335,15 +338,15 @@ void __init dc21285_preinit(void) 
	/*

	 * We don't care if these fail.

	 */

	request_irq(IRQ_PCI_SERR, dc21285_serr_irq, IRQF_DISABLED,

	dc21285_request_irq(IRQ_PCI_SERR, dc21285_serr_irq, IRQF_DISABLED,

			    "PCI system error", &serr_timer);

	request_irq(IRQ_PCI_PERR, dc21285_parity_irq, IRQF_DISABLED,

	dc21285_request_irq(IRQ_PCI_PERR, dc21285_parity_irq, IRQF_DISABLED,

			    "PCI parity error", &perr_timer);

	request_irq(IRQ_PCI_ABORT, dc21285_abort_irq, IRQF_DISABLED,

	dc21285_request_irq(IRQ_PCI_ABORT, dc21285_abort_irq, IRQF_DISABLED,

			    "PCI abort", NULL);

	request_irq(IRQ_DISCARD_TIMER, dc21285_discard_irq, IRQF_DISABLED,

	dc21285_request_irq(IRQ_DISCARD_TIMER, dc21285_discard_irq, IRQF_DISABLED,

			    "Discard timer", NULL);

	request_irq(IRQ_PCI_DPERR, dc21285_dparity_irq, IRQF_DISABLED,

	dc21285_request_irq(IRQ_PCI_DPERR, dc21285_dparity_irq, IRQF_DISABLED,

			    "PCI data parity", NULL);



	if (cfn_mode) {